Piersy/cherrypick goetherum access list gas fix #1873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 51.6% of statements across all listed packagescoverage: 61.4% of statements in consensus/istanbul coverage: 43.1% of statements in consensus/istanbul/announce coverage: 56.1% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 70.8% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 65.0% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 18d97595a4 |
Looks like revert is not safe for use across transaction boundaries. So instead of reverting changes to state we make a copy.
piersy
force-pushed
the
piersy/cherrypick-goetherum-access-list-gas-fix
branch
from
6a9a3ec to
a9a5cf6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
+ Coverage 54.32% 54.35% +0.02%
==========================================
Files 675 675
Lines 88959 88959
==========================================
+ Hits 48330 48355 +25
+ Misses 36981 36952 -29
- Partials 3648 3652 +4
Continue to review full report at Codecov.
|
|
The gas estimation problem was addressed in #1900, were currently merged up to v1.10.9 and the fix from upstream is included in 1.10.17 so we'll eventually get the upstream fix when we merge v1.10.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cherry picks ethereum/go-ethereum#24515
Which is a change to ensure that the access list is always emptied before applying a new transaction.
EIP-2929 Added the access list as a way to lower the cost of repeated accesses to the same address within the processing of a single transaction.
Prior to this fix certain code paths allowed gas estimation for a transaction to be initiated with a non empty access list. This resulted in gas estimations being lower than they should be, ultimately resulting in the transaction being rejected when an attempt to execute it is made.
Other changes
This change broke some of our code in the
mycelo/genesispackage where we were previously attempting to revert across multiple transaction boundaries.There could be other situations in the code where we attempt to revert across multiple transaction boundaries, so before we can confidently merge this pr we will need to analyse these cases to see if they could introduce any problems.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.