ci: Disable taplo #1540
Merged
ci: Disable taplo #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NunoAlexandre
commented
Sep 11, 2023
| @@ -190,7 +190,7 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "altair-runtime" | |||
| version = "0.10.31" | |||
| version = "0.10.32" | |||
There was a problem hiding this comment.
@mustermeiszer I guess my editor automatically fixed this issue (#1539). For me, you can merge your PR and then we merge this one; or we can merge this one into yours. Whatever you prefer :)
There was a problem hiding this comment.
Lets merge this one and close mine as this is hopefully all green and needs no force-merge and leaves not another broken commit on main.
Wdyt?
There was a problem hiding this comment.
Agreed! Thanks 🙏
cdamian
approved these changes
Sep 11, 2023
4 tasks
wischli
approved these changes
Sep 11, 2023
mustermeiszer
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taplo is suddenly failing to compile when installed on the CI but also locally. This is a commodity and we don't need this job on the CI, particularly in a phase as we are in with lots of work to get in.
Removing the job for now.