-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos #1568
fix: typos #1568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the corrections! 🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! One thing to fix
docs/runtime-upgrade.md
Outdated
@@ -43,15 +43,15 @@ This must be done before releasing a new version of any of our runtimes to ensur | |||
|
|||
- Click on **propose** | |||
|
|||
1. Voting phase. You should make 3 votes in favor with 3 diferent people (modify the CFG amount before to a low number). | |||
1. Voting phase. You should make 3 votes in favor of 3 different people (modify the CFG amount before to a low number). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That correction is not actually correct, since the desired semantic here is that 3 different accounts vote Aey
, note that someone "should make 3 votes in favour of 3 different people".
1. Voting phase. You should make 3 votes in favor of 3 different people (modify the CFG amount before to a low number). | |
1. Voting phase. Three different account should vote in favour of the proposal (modify the CFG amount before to a low number). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure we need 3 separate 👍 , 1 should be enough? 🤔 cc @wischli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure we need 3 separate 👍 , 1 should be enough? 🤔 cc @wischli
Our local chain specs setup 4 genesis council members
centrifuge-chain/src/chain_spec.rs
Lines 541 to 543 in 0387385
fn council_members_bootstrap() -> Vec<cfg_primitives::AccountId> { | |
endowed_accounts().into_iter().take(4).collect() | |
} |
Since both proposing an external referendum as well as fast-tracking requires at least half of the council, two votes would suffice. I suppose this is a remnant of previously requiring at least 75% of the council.
On that note, our runtime upgrade scripts votes with three members:
centrifuge-chain/scripts/js/upgrade/index.js
Lines 87 to 93 in 0387385
console.log("Continuing with council vote using", result[0], result[1]) | |
nonce = await getNonce(api, alice.address); | |
await councilVoteProposal(api, alice, result[0], result[1], nonce, false) | |
nonce = await getNonce(api, bob.address); | |
await councilVoteProposal(api, bob, result[0], result[1], nonce, false) | |
nonce = await getNonce(api, charlie.address); | |
await councilVoteProposal(api, charlie, result[0], result[1], nonce, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of votes must match the threshold set when proposing. The document currently states 3 (75%) which is outdated
1. In Governance -> Council -> Motions, click on **propose motion**.
- - At **umbral**, put `3` (a 75% of the total which is 4).
+ - At **umbral**, put `2` (a 50% of the total which is 4).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing our typos! As stated, some content of the readme should be updated as well most ideally. However, I am fine with merging these fixes as the content is not incorrect and fixing the details is out of scope of this PR in my opinion.
Co-authored-by: Nuno Alexandre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🙏
@omahs still interested in bringing this in? |
@mustermeiszer Hey, yes, should I edit something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
fix: typos