Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code coverage to pipeline #1745

Merged
merged 47 commits into from
Apr 2, 2024
Merged

add code coverage to pipeline #1745

merged 47 commits into from
Apr 2, 2024

Conversation

gpmayorga
Copy link
Contributor

Description

Add code coverage reports to our CI pipeline

Fixes #1617

Changes and Descriptions

Use tarpaulin to produce coverage reports

@gpmayorga gpmayorga requested a review from wischli as a code owner February 26, 2024 18:54
@gpmayorga gpmayorga marked this pull request as draft February 26, 2024 18:54
@gpmayorga gpmayorga marked this pull request as ready for review February 26, 2024 18:58
@lemunozm
Copy link
Contributor

Really cool feature!!

Just a couple of things.

  • Runtime weight files should not be counted for these statistics. Could they be filtered out?
  • Can we see the percentage of coverage per crate?

@lemunozm lemunozm self-requested a review February 27, 2024 07:28
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@1a9e385). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage        ?   47.64%           
=======================================
  Files           ?      170           
  Lines           ?    13587           
  Branches        ?        0           
=======================================
  Hits            ?     6473           
  Misses          ?     7114           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemunozm
Copy link
Contributor

It took almost 4 hours to compute all the tests; not sure why. Anyway, it seems to finally end with the test line of success. Nevertheless, the job still fails 🤔

lemunozm and others added 6 commits February 29, 2024 15:39
@lemunozm @wischli
Fix: FI swap correclty with asymmetric ratios (#1746)
6c8a521 
* fix by cancellation

* noop if currencies are different

* fix typos
@wischli
Fix: storage version mismatch + burn-unburned decoding issue (#1747)
f2a2a3e 
* feat: add storage bump migration

* fix: external altair migrations

* fix: external centrifuge migrations

* fix: clippy

* fix: burn_unburned migration v2

* chore: add version control to storage bump migration

* fix: celo usdc migration

* fix: remove undecodable storage entries altair
@wischli
fix: pub altair migration std
0ae2cf4
@gpmayorga
Merge branch 'main' into code-coverage
26af70c
@gpmayorga
bump machine and add llvm engine
7b7b3a5
@gpmayorga
try a half sized machine to see job times
5bbbc8d
gpmayorga added a commit that referenced this pull request Mar 6, 2024
@gpmayorga
move codecov to #1745
ea38819
lemunozm
lemunozm requested changes Mar 6, 2024
View reviewed changes
runtime/altair/src/migrations.rs Outdated Show resolved Hide resolved
gpmayorga added a commit that referenced this pull request Mar 7, 2024
@gpmayorga
Add some cool badges to our Readme (#1761)
2e45ffa 
* Add some badges to README

* fix

* release vs tag

* links

* move codecov to #1745
@gpmayorga gpmayorga added the D0-ready Pull request can be merged without special precaution and notification. label Mar 9, 2024
@gpmayorga
Copy link
Contributor Author

I think this is as far as we can go with the tarpaulin code coverage, if we wanted to include integration tests a collaborator from the team would have to successfully run the tarpaulin test without that flag and after that I could see how to make it work in the pipeline. Best to open a separate PR to resolve this rather than keeping this one open for a long time
@lemunozm @wischli

@gpmayorga gpmayorga mentioned this pull request Mar 9, 2024
Closed
12 tasks
@lemunozm
Copy link
Contributor

Agree! Let's merge this

@gpmayorga gpmayorga enabled auto-merge (squash) March 12, 2024 16:24
wischli
wischli approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving. Merging currently blocked because of @lemunozm's change request

@wischli wischli added the I12-ci Issue related to CI label Apr 2, 2024
lemunozm
lemunozm approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready!

@gpmayorga gpmayorga merged commit ccb6d3f into main Apr 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@lemunozm lemunozm lemunozm approved these changes

Assignees

@gpmayorga gpmayorga

Labels
D0-ready Pull request can be merged without special precaution and notification. I12-ci Issue related to CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA pipeline features
3 participants
@gpmayorga @lemunozm @wischli