fix: essence tranche token metadata #1798
Conversation
| tranche.currency.into(), | ||
| ), | ||
| ) | ||
| .ok_or(DispatchError::CannotLookup)?; |
There was a problem hiding this comment.
Thanks for cleaning that weird ok_or and removing the unwrap()
There was a problem hiding this comment.
Yeah that code path gave me shivers
| token_name: BoundedVec::try_from("ResName".as_bytes().to_owned()) | ||
| .expect("String not out of bounds"), | ||
| token_symbol: BoundedVec::try_from("ResSym".as_bytes().to_owned()) | ||
| .expect("String not out of bounds"), |
There was a problem hiding this comment.
NIT. If the test does not check token_name or token_symbol you can avoid initializing them using directly BoundedVec::default() to ease the reading of the test (same below)
There was a problem hiding this comment.
We are checking the tranche metadata in L2498 which is why I did not want to use default values here
There was a problem hiding this comment.
Ah ok, I didn't see it. Then everything is perfect!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
=======================================
Coverage 48.45% 48.45%
=======================================
Files 168 168
Lines 13331 13332 +1
=======================================
+ Hits 6459 6460 +1
Misses 6872 6872 ☔ View full report in Codecov by Sentry. |
Description
Slack thread
We can hold this until #1756 is merged
Changes and Descriptions
essencewhich is used forUpdatedeventChecklist: