Integration tests. Move EVM tests to the generic framework #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q3-medium
lemunozm
commented
Apr 8, 2024
| }); | ||
| } | ||
|
|
||
| crate::test_for_runtimes!([development], call); |
There was a problem hiding this comment.
When trying with altair or centrifuge I obtain a BadOrigin error (when I call pallet_evm::call() or pallet_evm::create()). Do you know what could be the reason?
There was a problem hiding this comment.
Not from the top of my head unfortunately, no idea what might cause that.
There was a problem hiding this comment.
I guess some constant we use in the test does not match the runtime config... any idea @mustermeiszer?
There was a problem hiding this comment.
Leaving this for a future PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
- Coverage 48.53% 48.53% -0.01%
==========================================
Files 167 167
Lines 13311 13311
==========================================
- Hits 6461 6460 -1
- Misses 6850 6851 +1 ☔ View full report in Codecov by Sentry. |
lemunozm
force-pushed
the
it/evm-to-generic
branch
from
10dfb46 to
13af112
Compare
lemunozm
force-pushed
the
it/evm-to-generic
branch
from
13af112 to
b03d7d5
Compare
wischli
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix partially #1790
Moving these tests to the generic framework:
NOTE: Blocked byREADYpolkadot-v1.1.0