-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Docker Swarm / Repackage as Docker Plugin #3769
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
+1 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
Still +1 |
Contributions from someone that has tested it on Docker Swarm are still welcome! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation. |
+1 |
I would also love to see this |
There seems some interest in this feature. Most of the regular Ceph-CSI contributors are not familiar with Docker Swarm, so it is not something that they easily can do. Contributions from others that would like to see this feature made available are most welcome! |
@nixpanic I would love to help out here at least with guidance, but sadly I don't have a working CEPH cluster to test this against. Any hints how to solve this (for dev at least)? |
Hmm, I always use Rook to deploy my Ceph cluster. But that obviously
won't work if you want to use Docker Swarm instead of Kubernetes.
The go-ceph project (https://github.com/ceph/go-ceph) runs CI with a
small Ceph cluster that is deployed by some scripts. You might be able
to use that to setup a small environment to test against.
|
Ah, you are proposing adapting this https://github.com/ceph/go-ceph/blob/9408dd58842306bca172192d320ea9cfab08065a/Makefile#L182 but leaving out the final testing step. Good idea, should work. |
Even though this is closed as an issue, I guess we can keep the discussion here? I plan to work on this when I have time, but I don't know exactly when that will be. |
I do not see why this issue closed when its clearly should not be. |
I'd like to second what @nixpanic mentioned in a comment above. I've reopened the issue and added keep alive label to avoid it from closing again. |
I 100% understand. That's why I am offering to help out. But as you know, time is a precious resource :). I will try to get some prototyping in, but that might not happen for a long time or it might happen over the weekend. I just don't know. So to anyone of the Swarm fans - if you want to work on this (maybe with my help) - reach out to me or join our Swarm Fans discord over at https://devops.fan . Then we can join efforts :). In general, I think that having a CEPH CSI provider for Swarm would be huge for anyone that is not on a cloud provider. |
Leaving some notes of prelimiary investigation here: The Docker volume plugin will require its own entrypoint as configuration needs to happen via environment variables with docker plugins. I have only found cephcsi.go which uses flags. |
Any news about this? |
I sadly have not found the time to work on this yet. |
+1 would be awesome to have this |
This would be amazing! |
Please? |
Volunteers are still very welcome, check this message from @s4ke on how anyone can help. |
+1 would be awesome to have this |
To anyone wanting to pick this up, seaweed has also been repackaged to be compatible with Docker Swarm now: https://github.com/seaweedfs/seaweedfs-csi-driver/tree/master/cmd/seaweedfs-csi-driver/swarm Maybe this helps. |
Describe the feature you'd like to have
Recently published Docker 23.0.0 added CSI support for Swarm mode so it is possible to use CSI drivers with it but they have to be packaged as Docker plugin.
What is the value to the end user? (why is it a priority?)
Docker Swarm users would gain the ability to use ceph in Docker Swarm via CSI instead of relying on bind mounting volumes.
How will we know we have a good solution? (acceptance criteria)
Additional context
You can find more information here. Hetzner CSI has already merged a PR that adds support
The text was updated successfully, but these errors were encountered: