Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: use docker.io for unqualified image names #1715

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

nixpanic
Copy link
Member

Images that have an unqualified name (no explicit registry) come from
Docker Hub. This can be made explicit by adding docker.io as prefix. In
addition, the default :latest tag has been added too.

By using the docker.io registry explicitly, it is possible to configure a
mirror for the registry, and point it to the local registry in the CI.

Updates: #1693


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@nixpanic nixpanic added component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/testing Additional test cases or CI work labels Nov 23, 2020
@nixpanic nixpanic requested a review from Madhu-1 November 23, 2020 13:34
@nixpanic
Copy link
Member Author

Adding [DNM] as the CI jobs do not configure the local mirror yet. The jobs also need to pull/push/tag the name with docker.io into minikube.

@nixpanic nixpanic added the DNM DO NOT MERGE label Nov 23, 2020
@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.19

@nixpanic nixpanic removed the DNM DO NOT MERGE label Nov 24, 2020
@nixpanic
Copy link
Member Author

#1717 has been merged, so dropping [DNM]

@Madhu-1 Madhu-1 added the ready-to-merge This PR is ready to be merged and it doesn't need second review (backports only) label Nov 24, 2020
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Nov 24, 2020

/test all

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm

Images that have an unqualified name (no explicit registry) come from
Docker Hub. This can be made explicit by adding docker.io as prefix. In
addition, the default :latest tag has been added too.

Signed-off-by: Niels de Vos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/testing Additional test cases or CI work ready-to-merge This PR is ready to be merged and it doesn't need second review (backports only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants