feat: Use env variable to configure number of workers #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
reviewed
Jun 21, 2024
| @@ -64,7 +64,10 @@ export class Multiprocess extends EventEmitter { | |||
| this.work() | |||
| return | |||
| } | |||
| let processes = options.workers || cpus().length // TODO workers = -1 or undef means no workers | |||
There was a problem hiding this comment.
Would be good to understand why cpus() is returning incorrect results in the first place.
There was a problem hiding this comment.
Otherwise this means having to constantly keep the env var updated when updating CAS resources in k8s.
There was a problem hiding this comment.
And changed the code to use settings from what's inside the Docker.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1233 +/- ##
==========================================
Coverage ? 75.30%
==========================================
Files ? 45
Lines ? 1936
Branches ? 320
==========================================
Hits ? 1458
Misses ? 478
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If env variable
MULTIPROCESS_SIZE(as a decimal number) is set, it takes precedence over nodejscpus().lengthofnode:os.That should fix a bug of "having" 32 processors on k8s regardless of the underlying number of CPUs.