Add known_gaps table
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will probably need to change the `modulus_block_number` columns name
Closed
abdulrabbani00
changed the title
known_gaps table - DO NOT MERGE YET!!known_gaps table
i-norden
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Table definition LGTM but we should add the migration as well. I agree we should change that column to modulus_block_number and we should also add another column, something like offset or slot_position. Then we can tell which blocks a specific service is handling no matter how we divide the work up (neglecting the confounding activity of the eth_probes that Rick poined out).
added 2 commits
March 31, 2022 10:45
|
@i-norden - My thought was that based off the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will probably need to change the
modulus_block_numbercolumns name