Refactoring intelmqctl #2067
Merged
Refactoring intelmqctl #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2067 +/- ##
===========================================
+ Coverage 76.03% 76.04% +0.01%
===========================================
Files 432 433 +1
Lines 23141 23193 +52
Branches 3095 3100 +5
===========================================
+ Hits 17595 17637 +42
- Misses 4839 4849 +10
Partials 707 707
|
ghost
force-pushed
the
schacht/intelmqctl-refactor
branch
10 times, most recently
from
16f2f11 to
70e7174
Compare
This commit introduces a separate module for the processmanagers. The module also contains a processmanager interface all the processmanager should adhere to. The commit also moves some of the commonly used values to the datatypes module, so that therer is a central place for them to reside in. Both the processmanagers and the intelmqctl command were cleaned up a bit.
ghost
force-pushed
the
schacht/intelmqctl-refactor
branch
from
70e7174 to
39eaf2a
Compare
ghost
marked this pull request as ready for review
ghost
added this to the
ghost
approved these changes
Aug 30, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a separate module for the processmanagers. The
module also contains a processmanager interface all the processmanager
should adhere to.