FIX: threshold expert: configure timeout using Redis cache mixin #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Redis cache functionality was moved to a mixin, the code that set the cache timeout from the "timeout" parameter was removed, but the error checking and documentation remained. Change documentation and configuration checking code to refer to the standard redis_cache_ttl parameter instead. Also remove some redundant default values which are now set in the cache mixin. Fixes: 2a1b126 ("FIX: Use CacheMixins instead of lib.cache") Signed-off-by: Karl-Johan Karlsson <[email protected]>
sebix
added
bug
add note to news and changelog, make parameter more clear in bots documentation section
Codecov Report
@@ Coverage Diff @@
## develop #2155 +/- ##
===========================================
- Coverage 76.34% 76.34% -0.01%
===========================================
Files 441 441
Lines 23652 23649 -3
Branches 3739 3739
===========================================
- Hits 18058 18055 -3
Misses 4857 4857
Partials 737 737
|
sebix
approved these changes
Mar 5, 2022
|
For reasons I don't understand the tests are now failing :/ |
jinja2 version 3 did not introduce breaking changes, so we can remove the version restriction add the requirement also for the jinja expert fix error message on the required library in the jinja expert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Redis cache functionality was moved to a mixin, the code that
set the cache timeout from the "timeout" parameter was removed, but
the error checking and documentation remained. Change documentation and
configuration checking code to refer to the standard redis_cache_ttl
parameter instead.
Also remove some redundant default values which are now set in the
cache mixin.
Fixes: 2a1b126 ("FIX: Use CacheMixins instead of lib.cache")