Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql output: escape all null bytes #2223

Merged
merged 1 commit into from
Aug 1, 2022
Merged

postgresql output: escape all null bytes #2223

merged 1 commit into from
Aug 1, 2022

Conversation

wagner-intevation
Copy link
Contributor

while null bytes (\0, not SQL "NULL") in TEXT and JSON/JSONB fields are valid, data containing null bytes can cause troubles in some combinations of clients, servers and each settings.
To prevent unhandled errors, and data which can't be inserted into the database, all null bytes are escaped

fixes #2203

@wagner-intevation wagner-intevation marked this pull request as ready for review July 25, 2022 10:10
@sebix sebix requested a review from waldbauer-certat July 25, 2022 10:10
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: bots labels Jul 25, 2022
@sebix sebix added this to the 3.1.0 milestone Jul 25, 2022
@sebix sebix force-pushed the fix-2203 branch 2 times, most recently from c75c21d to 09c75d1 Compare July 25, 2022 13:47
while null bytes (`\0`, not SQL "NULL") in TEXT and JSON/JSONB fields are valid, data containing null bytes can cause troubles in some combinations of clients, servers and each settings.
To prevent unhandled errors, and data which can't be inserted into the database, all null bytes are escaped

fixes #2203
Copy link
Contributor

@waldbauer-certat waldbauer-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL Output: Issue with Nullbytes in JSON-Data
3 participants