Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Updates Turris Greylist parser and feed URL #2375

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

gethvi
Copy link
Contributor

@gethvi gethvi commented Jun 13, 2023

Fixes #2167.

@gethvi gethvi force-pushed the fix-2167 branch 4 times, most recently from e238551 to 4b755bd Compare June 13, 2023 16:16
@sebix
Copy link
Member

sebix commented Jun 13, 2023

____________________ TestUpgradeLib.test_all_functions_used ____________________

self = <intelmq.tests.lib.test_upgrades.TestUpgradeLib testMethod=test_all_functions_used>

    def test_all_functions_used(self):
        self.assertEqual(len(self.mapping_list_name),
                         len(set(self.mapping_list_name)),
                         msg='Some function is assigned to multiple versions.')
        self.assertEqual(set(self.allfs),
                         set(self.mapping_list_name),
>                        msg='v* functions in the module do not '
                             'match the mapping.')
E       AssertionError: Items in the second set but not the first:
E       'v320_update_turris_greylist_url' : v* functions in the module do not match the mapping.

intelmq/tests/lib/test_upgrades.py:579: AssertionError

The function is not listed in __all__

@@ -38,6 +38,7 @@
'v301_deprecations',
'v310_feed_changes',
'v310_shadowserver_feednames',
'v320_update_turris_greylist_url'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'v320_update_turris_greylist_url'
'v320_update_turris_greylist_url',

sorry for bothering again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. :)

@sebix sebix merged commit 61c45ac into certtools:develop Jun 21, 2023
@sebix sebix added this to the 3.2.0 milestone Jun 21, 2023
@gethvi gethvi deleted the fix-2167 branch March 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turris greylist has been updated
2 participants