Avoid stucking while reading stdout from pty #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge it if possible 🙏 Just spent 3 hours trying to figure out why my service hangs on a completely unexpected point. But it actually didn't hang, it was just silence in stdout because of this bug. |
|
I fixed this in a different way in 13e5691 and tagged v0.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewScanner is unable to read lines that exceed 64*1024 bytes in length, resulting in an error. However, reflex ignores Scan errors, so when the command being executed produces a large output, reflex will block and the command itself will stop.
By using ReadLine, it is possible to divide the output into multiple reads even if it is large.