Merge pull request #212 from cevoaustralia/merge-happyzippy

Merge happyzippy
cevoaustralia · Jan 28, 2021 · 3f3b73b · 3f3b73b
2 parents f5c71e7 + 5604cff
commit 3f3b73b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.rst b/README.rst
@@ -279,6 +279,9 @@ by this tool are:
 | Security key     | ``.../signin/challenge/sk/...``     |
 |  (eg yubikey)    |                                     |
 +------------------+-------------------------------------+
+| Dual prompt      | ``.../signin/challenge/dp/...``     |
+|  (Validate 2FA ) |                                     |
++------------------+-------------------------------------+
 | Backup code      | ``... (unknown yet) ...``           |
 |  (printed codes) |                                     |
 +------------------+-------------------------------------+

diff --git a/aws_google_auth/google.py b/aws_google_auth/google.py
@@ -357,8 +357,8 @@ def parse_saml(self):
             if self.save_failure:
                 logging.error("SAML lookup failed, storing failure page to "
                               "'saml.html' to assist with debugging.")
-                with open("saml.html", 'w') as out:
-                    out.write(str(self.session_state.text.encode('utf-8')))
+                with open("saml.html", 'wb') as out:
+                    out.write(self.session_state.text.encode('utf-8'))
 
             raise ExpectedGoogleException('Something went wrong - Could not find SAML response, check your credentials or use --save-failure-html to debug.')