prevent usage of keyring in test_process_auth_dont_resolve_alias #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing for #86 there was a failing test (
test_process_auth_dont_resolve_alias
) only on my local machine.The test was failing (remotely) because the
Google Password:
prompt was presented when not expected.Test were failing only on Travis, and not on my laptop, which was unexpected. Also, test where failing using the
origin/master
branch ( in my fork ) up to date withupstream/master
, which was unexpected because Travis build for upstream master are green. This shown that the problem is not related to the PR #86.So:
origin/master
up to date withupstream/master
This was happening because that test was writing in the my laptop keyring 😓 : at first run the
pass
value was saved in the keyring, making all successive test run failing.The
Google Password
prompt, which was expected, was not run after the first time, because the value was being retrieved from keyring.This PR force the
config
mockkeyring
toFalse
, in order to never use the keyring: this way the prompt is always present and tests are happy.