Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent usage of keyring in test_process_auth_dont_resolve_alias #88

Conversation

endorama
Copy link
Contributor

During testing for #86 there was a failing test (test_process_auth_dont_resolve_alias) only on my local machine.

The test was failing (remotely) because the Google Password: prompt was presented when not expected.

Test were failing only on Travis, and not on my laptop, which was unexpected. Also, test where failing using the origin/master branch ( in my fork ) up to date with upstream/master, which was unexpected because Travis build for upstream master are green. This shown that the problem is not related to the PR #86.

So:

  • test failing on local machine for origin/master up to date with upstream/master
  • test not failing on Travis
  • test not failing on local machine the first time
  • test failing on local machine after the first time

This was happening because that test was writing in the my laptop keyring 😓 : at first run the pass value was saved in the keyring, making all successive test run failing.
The Google Password prompt, which was expected, was not run after the first time, because the value was being retrieved from keyring.

This PR force the config mock keyring to False, in order to never use the keyring: this way the prompt is always present and tests are happy.

@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage decreased (-0.6%) to 48.362% when pulling 9dfe10c on endorama:fix_test_process_auth_dont_resolve_alias into 53a89b8 on cevoaustralia:master.

Copy link
Contributor

@stevemac007 stevemac007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pickup - thanks

@stevemac007 stevemac007 merged commit 4820183 into cevoaustralia:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants