Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Add support for parsing submodules #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pswaminathan
Copy link
Contributor

No description provided.

@pswaminathan pswaminathan force-pushed the umbrella-and-inferred-submodules branch from 385747c to 35cc258 Compare May 22, 2022 21:50
@cgrindel
Copy link
Owner

cgrindel commented Jun 8, 2022

Sorry for the radio silence on this end. I am out on vacation for the next week and a half. I will take a look at this PR when I am back online.

@cgrindel
Copy link
Owner

cgrindel commented Sep 3, 2022

@pswaminathan I am so sorry for the delay in reviewing this. It fell off of my radar. Thank you for sending it.

I think that the submodule parsing should run through the same parsing code as the module parsing. Since we cannot rely on recursive functions, I am thinking that we implement it like so:

  1. Extract the submodule tokens,
  2. Return unprocessed submodule tokens as a declaration,
  3. The top-level module function detects the unprocessed submodule declaration and runs it through the module processing

What do you think? I am working on an implementation. I will send it out for review when I have something that works.

@cgrindel
Copy link
Owner

cgrindel commented Sep 6, 2022

@pswaminathan I added my first pass at submodule parsing in #169. If that looks reasonable to you, do you think we should close this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants