Chore: change coverage service (coverall to codecov) #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason of change mentioned on chaijs#927 This patch: - add codecov as devDep, as it's not pre-installed by travis. - add codecov script on travis. - change badge link (coverall to codecov), and point the image to chai account on codecov. Fix chaijs#927
|
Just reminder, since the badge link is pointing to chai account on codecov. Kindly complete the sign-up process on codecov. |
keithamus
approved these changes
Oct 30, 2017
meeber
approved these changes
Oct 30, 2017
|
I just did it. We're good to merge 😄 |
|
Good work @brutalcrozt 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason of change mentioned on #927
This patch:
- add codecov as devDep, as it's not pre-installed by travis.
- add codecov on travis's script section.
- change badge link (coverall to codecov), and point the image to chai account on codecov.
Fix #927