added check for logging negative zero #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,6 +191,9 @@ function formatPrimitive(ctx, value) { | |||
| return ctx.stylize(simple, 'string'); | |||
|
|
|||
| case 'number': | |||
| if (value === 0 && Infinity !== (1 / value)) { | |||
There was a problem hiding this comment.
Nice work @dasilvacontin but there is some serious reverse logic going on here. Surely this would be better written as value === 0 && (1/value) === -Infinity?
There was a problem hiding this comment.
I totally agree with that! Thanks for pointing it out, @keithamus ! 😄
|
LGTM. @logicalparadox am I good to merge? |
|
Missing test asserting this works. |
|
👍 |
|
Added some assertions. If it needs any other change, suggestions are welcome. |
|
👍 |
keithamus
added a commit
that referenced
this pull request
Nov 3, 2014
added check for logging negative zero
|
Sorry @logicalparadox about missing the test - I'll ensure to be extra vigilant next time! |
|
Sorry for missing it too! :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Lexicality mentions in issue #223, when asserting
0against-0, Chai throwsAssertionError: expected 0 to deeply equal 0without any further information.With the check in this PR, Chai throws
AssertionError: expected 0 to deeply equal -0.