Set txs to empty list #7
Conversation
cmd/geth/main.go
Outdated
| @@ -183,6 +183,7 @@ var ( | |||
| utils.BuilderDiscardRevertibleTxOnErr, | |||
| utils.BuilderEnableCancellations, | |||
| utils.BuilderBlockProcessorURL, | |||
| utils.BuilderVerifyConstraints, | |||
There was a problem hiding this comment.
Thanks for the fix, however I don't think this is enough because theBuilderVerifyConstraints flag isn't correctly propagated to where builder service is started because it is not read when creating the BuilderArgs struct to start the relay:
bolt-builder/builder/service.go
Lines 292 to 307 in 45fe6e9
By looking at the diffs this might be an oversight on our side when this has been introduced in 5f66af8. I can fix that.
There was a problem hiding this comment.
Haha good catch :) I haven't really looked into it enough yet!
| plainTxs := newTransactionsByPriceAndNonce(env.signer, make(map[common.Address][]*txpool.LazyTransaction), nil, nil, env.header.BaseFee) | ||
| blobTxs := newTransactionsByPriceAndNonce(env.signer, make(map[common.Address][]*txpool.LazyTransaction), nil, nil, env.header.BaseFee) | ||
|
|
||
| if err := w.commitTransactions(env, plainTxs, blobTxs, constraints, interrupt); err != nil { | ||
| return nil, nil, nil, err | ||
| } | ||
| } | ||
| if len(remotePlainTxs) > 0 || len(remoteBlobTxs) > 0 || len(constraints) > 0 { | ||
| plainTxs := newTransactionsByPriceAndNonce(env.signer, remotePlainTxs, nil, nil, env.header.BaseFee) | ||
| blobTxs := newTransactionsByPriceAndNonce(env.signer, remoteBlobTxs, nil, nil, env.header.BaseFee) | ||
| plainTxs := newTransactionsByPriceAndNonce(env.signer, make(map[common.Address][]*txpool.LazyTransaction), nil, nil, env.header.BaseFee) | ||
| blobTxs := newTransactionsByPriceAndNonce(env.signer, make(map[common.Address][]*txpool.LazyTransaction), nil, nil, env.header.BaseFee) |
There was a problem hiding this comment.
Can we gate this to a flag BuilderConstraintsWithoutMempool (or similar name)?
There was a problem hiding this comment.
Oh I wasn't planning on this PR ever being merged, this was just for current community driven usage
There was a problem hiding this comment.
As you wish! For us it's not a problem to add some flags if requested :)
📝 Summary
📚 References
CONTRIBUTING.md