feat(sidecar): fix nits

bolt-sidecar/bin/sidecar.rs

@@ -45,7 +45,6 @@ async fn main() -> eyre::Result<()> {
 
     api_server.run(api_events).await?;
 
-    // let shutdown_tx = start_rpc_server(&config, api_events).await?;
     let mut consensus_state = ConsensusState::new(
         beacon_client.clone(),
         config.validator_indexes.clone(),
@@ -182,7 +181,6 @@ async fn main() -> eyre::Result<()> {
             },
             Ok(_) = tokio::signal::ctrl_c() => {
                 tracing::info!("Received SIGINT, shutting down...");
-                // shutdown_tx.send(()).await.ok();
                 break;
             }
         }

bolt-sidecar/src/api/commitments/server.rs

@@ -106,11 +106,11 @@ impl CommitmentsApiServer {
     }
 
     /// Creates the server with the given address and shutdown signal.
-    pub fn with_shutdown<A: ToSocketAddrs>(
-        self,
-        addr: A,
-        signal: impl Future<Output = ()> + Send + 'static,
-    ) -> Self {
+    pub fn with_shutdown<A, S>(self, addr: A, signal: S) -> Self
+    where
+        A: ToSocketAddrs,
+        S: Future<Output = ()> + Send + 'static,
+    {
         Self {
             addr: addr.to_socket_addrs().unwrap().next().unwrap(),
             signal: Some(Box::pin(signal)),
@@ -211,8 +211,8 @@ impl CommitmentsApiServer {
 
                 Ok(Json(response))
             }
-            _ => {
-                tracing::error!("Unknown method: {}", payload.method);
+            other => {
+                tracing::error!("Unknown method: {}", other);
                 Err(Error::UnknownMethod)
             }
         }

bolt-sidecar/src/api/commitments/spec.rs

@@ -26,7 +26,7 @@ pub enum Error {
     #[error("Internal server error")]
     Internal,
     /// Missing signature.
-    #[error("Missing X-Bolt-Signature header")]
+    #[error("Missing '{SIGNATURE_HEADER}' header")]
     NoSignature,
     /// Invalid signature.
     #[error(transparent)]