Skip to content

Commit

Permalink
chore: add todo comment on commitment auth
Browse files Browse the repository at this point in the history
  • Loading branch information
merklefruit committed May 31, 2024
1 parent e7e49ab commit f3e2e45
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions bolt-sidecar/src/json_rpc/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ impl CommitmentsRpc for JsonRpcApi {
let user_sig = Signature::from_str(params.signature.trim_start_matches("0x"))?;
let signer_address = user_sig.recover_address_from_msg(params.message.digest().as_ref())?;

// TODO: relax this check to allow for external signers to request commitments
// about transactions that they did not sign themselves
if signer_address != tx_sender {
return Err(ApiError::Custom(
"commitment signature does not match the transaction sender".to_string(),
Expand Down

0 comments on commit f3e2e45

Please sign in to comment.