fix(sidecar): hex private key #118
Conversation
WalkthroughThe recent changes in Changes
Sequence Diagram(s)None provided due to simplicity of changes. Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
namn-grg
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- bolt-sidecar/src/config/mod.rs (2 hunks)
Additional comments not posted (1)
bolt-sidecar/src/config/mod.rs (1)
212-213: LGTM!The assignment of
config.fee_recipientlooks good.
| // Check if the string starts with "0x" and remove it | ||
| let hex_sk = if sk.starts_with("0x") { &sk[2..] } else { &sk }; | ||
|
|
||
| let sk = SecretKey::from_bytes(&hex::decode(hex_sk)?) |
There was a problem hiding this comment.
Improve error handling for invalid hex strings.
The current code does not handle cases where the hex string might still be invalid after removing the "0x" prefix. Consider adding additional checks or handling for such cases.
- let sk = SecretKey::from_bytes(&hex::decode(hex_sk)?)
- .map_err(|e| eyre::eyre!("Failed decoding BLS secret key: {:?}", e))?;
+ let decoded_hex = hex::decode(hex_sk).map_err(|e| eyre::eyre!("Failed decoding hex string: {:?}", e))?;
+ let sk = SecretKey::from_bytes(&decoded_hex)
+ .map_err(|e| eyre::eyre!("Failed decoding BLS secret key: {:?}", e))?;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Check if the string starts with "0x" and remove it | |
| let hex_sk = if sk.starts_with("0x") { &sk[2..] } else { &sk }; | |
| let sk = SecretKey::from_bytes(&hex::decode(hex_sk)?) | |
| // Check if the string starts with "0x" and remove it | |
| let hex_sk = if sk.starts_with("0x") { &sk[2..] } else { &sk }; | |
| let decoded_hex = hex::decode(hex_sk).map_err(|e| eyre::eyre!("Failed decoding hex string: {:?}", e))?; | |
| let sk = SecretKey::from_bytes(&decoded_hex) | |
| .map_err(|e| eyre::eyre!("Failed decoding BLS secret key: {:?}", e))?; |
|
Awesome! |
fixes #114
Summary by CodeRabbit
config.fee_recipient.