chore: add commitment validity tests #130

merklefruit · 2024-07-15T08:35:51Z

refactored execution tests to use a streamlined test_util module for signing and creating commitment requests
added the has_code property to the AccountState fetched during commitment request validation.
added other minor commitment validity checks such as gas_limit and tx_size

Having the account code check prevents accepting preconfirmation requests from smart contracts addresses.
Not entirely sure how this would be possible in the real world, but EL clients are also performing this check.

coderabbitai · 2024-07-15T08:35:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

thedevbirb

Great job, just a q

thedevbirb · 2024-07-15T15:03:40Z

bolt-sidecar/src/state/execution.rs

+    /// Constant values used for validation
+    constants: Constants,
+}
+
+/// Constants used for validation.
+#[derive(Debug)]
+pub struct Constants {
+    block_gas_limit: u64,
+    max_tx_input_bytes: usize,
+    #[allow(unused)]
+    max_init_code_byte_size: usize,
+}
+
+impl Default for Constants {
+    fn default() -> Self {
+        Self {
+            block_gas_limit: 30_000_000,
+            max_tx_input_bytes: 4 * 32 * 1024, // 128kb
+            max_init_code_byte_size: 2 * 24576,
+        }
+    }
 }


Why are you putting these constants in a struct field compared to being just constants in the code?

Because these should be configurable in theory, but I'm not fully convinced if this is useful now.
What makes more sense in your opinion?

Why should they be configurable in theory? Just curious, I thought this values could change only with an hard-fork

these values are chosen by the EL, and can be configured via CLI, without hardforks

thedevbirb force-pushed the fix/sidecar/constraints-deadline branch from afe583b to cb71464 Compare July 15, 2024 08:54

merklefruit force-pushed the feat/invalidate-state branch from 3386bf3 to 2b4ce27 Compare July 15, 2024 09:17

merklefruit marked this pull request as ready for review July 15, 2024 13:18

merklefruit requested review from thedevbirb, mempirate and namn-grg and removed request for thedevbirb, mempirate and namn-grg July 15, 2024 13:18

thedevbirb reviewed Jul 15, 2024

View reviewed changes

merklefruit force-pushed the feat/invalidate-state branch from 754e949 to c77b8c2 Compare July 16, 2024 07:48

merklefruit added 8 commits July 16, 2024 16:17

wip: commitment test utils

86ac3fc

chore: small nit

48a68d1

feat: cleaned tests with test_util

87a0ac2

chore: added todo

52ec1b2

chore: added tx validation constantsC

3d8ca34

feat: added code check

e8e4d9c

feat: init code check

5e3db9e

chore: small fixes

6ca40c5

merklefruit force-pushed the feat/invalidate-state branch from 47fcec9 to 6ca40c5 Compare July 16, 2024 14:19

chore: rename

edf065c

thedevbirb approved these changes Jul 16, 2024

View reviewed changes

thedevbirb merged commit aa021ab into fix/sidecar/constraints-deadline Jul 16, 2024

thedevbirb deleted the feat/invalidate-state branch July 16, 2024 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add commitment validity tests #130

chore: add commitment validity tests #130

merklefruit commented Jul 15, 2024 •

edited

Loading

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

thedevbirb left a comment

thedevbirb Jul 15, 2024 •

edited

Loading

merklefruit Jul 15, 2024

thedevbirb Jul 16, 2024

merklefruit Jul 16, 2024

chore: add commitment validity tests #130

chore: add commitment validity tests #130

Conversation

merklefruit commented Jul 15, 2024 • edited Loading

coderabbitai bot commented Jul 15, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

thedevbirb left a comment

Choose a reason for hiding this comment

thedevbirb Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

merklefruit Jul 15, 2024

Choose a reason for hiding this comment

thedevbirb Jul 16, 2024

Choose a reason for hiding this comment

merklefruit Jul 16, 2024

Choose a reason for hiding this comment

merklefruit commented Jul 15, 2024 •

edited

Loading

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

thedevbirb Jul 15, 2024 •

edited

Loading