-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devnet): build docker images using --load flag #131
Conversation
WalkthroughThe recent changes in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- Justfile (1 hunks)
Additional comments not posted (4)
Justfile (4)
112-112
: LGTM!The addition of the
--load
flag ensures that the built image is loaded into Docker.
116-116
: LGTM!The addition of the
--load
flag ensures that the built image is loaded into Docker.
120-120
: LGTM!The addition of the
--load
flag ensures that the built image is loaded into Docker.
124-124
: LGTM!The addition of the
--load
flag ensures that the built image is loaded into Docker.
Apparently, new docker versions (using
v24.0.9
) require a--load
flag to actually load the image into docker, otherwise it will be just kept in the cache, as outlined by this warning after the commanddocker buildx build -t ghcr.io/chainbound/bolt-mev-boost:0.1.0 .
:Such flag is now introduced in the
justfile
for all building commandsSummary by CodeRabbit
--load
flag, optimizing the image building process in the container registry setup.