Fix devnet with constraints deadline #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thedevbirb
commented
Jul 16, 2024
•
thedevbirb
commented
- fixed a bug in the builder constraint cache timing: since we are now sending commitments towards the end of the slot, we cannot rely on fetching them when we start building for a specific slot. Instead, we keep the constraints cache downstream and constantly fetch from it to get the latest values each time a new worker is run.
- fixed an issue where the sidecar would throw a "payload header equivocation" error due to the local_payload cache not being cleared when getting a signed header back from the CL.
…payload attributes, which is called immediately in the slot before the commitment deadline Co-authored-by: nicolas <[email protected]>
… sign a local header Co-authored-by: nicolas <[email protected]>
thedevbirb
added
C: bolt-sidecar
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
merklefruit
reviewed
Jul 16, 2024
Comment on lines
+128
to
+131
| // Clear the local payload cache if we have a successful response | ||
| // By definition of `server.local_payload`, this will be `Some` IFF we have signed a local header | ||
| let mut local_payload = server.local_payload.lock(); | ||
| *local_payload = None; |
There was a problem hiding this comment.
since local_payload doesn't have a slot number, it was possible to get a stale block from this and result in a conflicting block hash in get_payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.