fix(mevboost, relay): ordering logic for multiproofs #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mempirate
reviewed
Jul 26, 2024
| @@ -50,17 +61,14 @@ func verifyInclusionProof(log *logrus.Entry, transactionsRoot phase0.Root, proof | |||
| } | |||
|
|
|||
| leaves[i] = txHashTreeRoot[:] | |||
| indexes[i] = int(proof.GeneralizedIndexes[i]) | |||
There was a problem hiding this comment.
Should we be careful with converting from uin64 to int64 here?
There was a problem hiding this comment.
This is safe because max i64 is 9,223,372,036,854,775,807 and all generalized indexes for transactions are capped at 2^22 -1 = 4,194,303 by consensus specs
There was a problem hiding this comment.
For the multiproof verification it is required that indexes is a []int. Given that generalized indexes will reasonably be small numbers (in the order of
mempirate
approved these changes
Jul 26, 2024
merklefruit
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some internal discussion we figured out that our MEV-Boost and relay fork don't need to sort the unindexed constraints like builder does, see #162 for context, but it is sufficient that the
InclusionProofstruct satisfies the following property:An example is the following: if on a block$B$ I have two preconfirmed transactions $T_1$ and $T_2$ at index $i_1$ , $i_2$ respectively and $g_1$ , $g_2$ are their generalized indexes, then the proof data must be:
or, equivalently