fix(sidecar): process pending bundle diffs #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When validating requests containing multiple transactions, we need to take into account the previous transactions in the bundle as increasing the nonce (and decreasing the balance) of the account that sent it, even if they haven't been committed yet to the template.
This fixes the issue by introducing two maps to keep track of the pending state due to these requests.
Note that if anything in the request fails validation, the whole bundle won't be committed, as expected.
Tests
v0.1.3-alpha.rc2