Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidecar): add bolt_getVersion RPC method #172

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Jul 29, 2024

Added an endpoint to fetch the version of the Bolt-sidecar,
so that external consumers know which functionalities are implemented.

Also added a couple debug logs to inspect some issues with bundle inclusion preconfirmations on Helder.

@merklefruit merklefruit marked this pull request as draft July 30, 2024 08:59
@merklefruit merklefruit changed the title feat(sidecar): add /version endpoint feat(sidecar): add bolt_getVersion RPC endpoint Jul 30, 2024
@merklefruit merklefruit changed the title feat(sidecar): add bolt_getVersion RPC endpoint feat(sidecar): add bolt_getVersion RPC method Jul 30, 2024
@merklefruit merklefruit marked this pull request as ready for review July 30, 2024 13:22
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merklefruit merklefruit merged commit f3e6808 into unstable Jul 31, 2024
2 checks passed
@merklefruit merklefruit deleted the chore/sidecar/version branch July 31, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(sidecar): expose a version endpoint
2 participants