fix(sidecar): bundle verification logic #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! (Pic unrelated)
|
merklefruit
approved these changes
Aug 1, 2024
|
Proof of ItWorks™️ https://dora.helder-devnets.xyz/slot/296234: three preconfs from the same address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sidecar we've recently introduced bundle support, which need special nonce and balance checks when verified.
In particular, when processing the next transaction in the bundle we should increment the user nonce and decrease its balance, however this operationis done before the transaction validation and not at the end of the loop, causing an off-by-one error in nonce checks (
NonceTooLow)