Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mev-boost-relay): set SSZ max constraints per slot to the defau… #185

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

merklefruit
Copy link
Collaborator

…lt max transactions per block

closes #61

}

type Constraint struct {
Tx Transaction `ssz-max:"1048576" json:"tx"`
Tx Transaction `ssz-max:"1073741824" json:"tx"`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this value was wrong, however we only use JSON for this type currently.
We should either remove SSZ definitions for it or start using it.

@merklefruit merklefruit requested a review from mempirate August 6, 2024 09:28
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@merklefruit merklefruit merged commit b0d0786 into unstable Aug 6, 2024
2 checks passed
@merklefruit merklefruit deleted the nico/chore/set-max-constraints branch August 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide the value of the constant MAX_CONSTRAINTS_PER_SLOT
2 participants