fix: build local payload with timestamp from beacon clock #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Aug 9, 2024
merklefruit
commented
Aug 9, 2024
namn-grg
reviewed
Aug 9, 2024
Comment on lines
+231
to
+234
| /// Fetch the previous RANDAO value from the beacon chain. | ||
| /// | ||
| /// NOTE: for some reason, using the ApiResult from `beacon_api_client` doesn't work, so | ||
| /// we are making a direct request to the beacon client endpoint. |
There was a problem hiding this comment.
hmm just curious to know some more detail
There was a problem hiding this comment.
I think it has to do with the type that the beacon_api_client crate expects to deserialize from the result of that API call - maybe it has changed or it's not updated to what Lighthouse is responding, so it fails to deserialize.
This is probably a bug in the beacon_api_client crate - but I haven't investigated
namn-grg
approved these changes
Aug 9, 2024
|
Great catch ser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the edge case in which the previous slot was missed by the proposer before us, and we would
use the wrong block timestamp. Now we use the timestamp according to the beacon proposal slot instead.
This also contains minor refactoring to the local payload fetcher to be a little cleaner.