Telemetry & Metrics #204
Merged
Telemetry & Metrics #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
added
C: bolt-sidecar
|
can you add some docs related to telemetry in the sidecar's readme? |
merklefruit
requested changes
Aug 29, 2024
thedevbirb
force-pushed
the
lore/feat/sidecar/telemetry-metrics
branch
from
bf3335a to
f46e580
Compare
mempirate
reviewed
Aug 29, 2024
bolt-sidecar/src/config/mod.rs
Outdated
| /// Metrics port | ||
| pub metrics_port: u16, | ||
| /// Toggle for metrics | ||
| pub metrics: bool, |
There was a problem hiding this comment.
Can we make this --disable-metrics instead?
namn-grg
approved these changes
Aug 30, 2024
merklefruit
reviewed
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116.
Introduces telemetry and metrics into the Bolt sidecar, which are enabled using the
metricsflag, by spinning up a Prometheus server and basic Grafana dashboard, which are available also for the devnet (see chainbound/ethereum-package#7).The integration with Promtail and Loki will be addressed in a future PR if needed.
NOTE:
telemetry.compose.ymlis currently non-tested on Helder. Main testing has been done with devnet data.Lastly, most of the code is heavily inspired by the work of @merklefruit and @namn-grg on https://github.com/chainbound/bolt-rpc, so thanks a lot for the guideline!