Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt-boost module #207

Merged
merged 29 commits into from
Sep 5, 2024
Merged

Bolt-boost module #207

merged 29 commits into from
Sep 5, 2024

Conversation

mempirate
Copy link
Contributor

@mempirate mempirate commented Sep 2, 2024

Context

This PR implements a new commit-boost module with the constraints-API.

Closes #90

@mempirate mempirate marked this pull request as ready for review September 5, 2024 10:28
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review! Great work, going to take a better look at the server.rs, types.rs files later

bolt-boost/Cargo.toml Outdated Show resolved Hide resolved
bolt-boost/Cargo.toml Outdated Show resolved Hide resolved
bolt-boost/src/constraints.rs Outdated Show resolved Hide resolved
bolt-boost/src/constraints.rs Outdated Show resolved Hide resolved
bolt-boost/src/proofs.rs Show resolved Hide resolved
bolt-boost/src/proofs.rs Show resolved Hide resolved
bolt-sidecar/Cargo.toml Show resolved Hide resolved
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left mostly questions to understand the entire flow

bolt-boost/src/constraints.rs Show resolved Hide resolved
bolt-boost/src/proofs.rs Show resolved Hide resolved
bolt-boost/src/server.rs Outdated Show resolved Hide resolved
bolt-boost/src/server.rs Outdated Show resolved Hide resolved
bolt-boost/src/server.rs Outdated Show resolved Hide resolved
bolt-boost/src/server.rs Outdated Show resolved Hide resolved
bolt-boost/src/main.rs Outdated Show resolved Hide resolved
bolt-boost/src/server.rs Show resolved Hide resolved
@merklefruit
Copy link
Collaborator

One last nit: we're using standardized rustfmt rules across our packages, can you apply them to this one too?
it's just a new file rustfmt.toml:

reorder_imports = true
imports_granularity = "Crate"
use_small_heuristics = "Max"
comment_width = 100
wrap_comments = true
binop_separator = "Back"
trailing_comma = "Vertical"
trailing_semicolon = false
use_field_init_shorthand = true
format_code_in_doc_comments = true
doc_comment_code_block_width = 100

then we can use auto-formatting with LSPs and cargo fmt --all to do it manually.

Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of q's on the server code

bolt-boost/src/server.rs Outdated Show resolved Hide resolved
bolt-boost/src/server.rs Outdated Show resolved Hide resolved
@merklefruit merklefruit added this to the v0.3: Holesky 1 milestone Sep 5, 2024
@mempirate mempirate merged commit a45077c into unstable Sep 5, 2024
2 checks passed
@merklefruit merklefruit deleted the feat/bolt-boost branch September 5, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement hash tree root for ConstraintsMessage
4 participants