Smart contracts: Registry + Challenger #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.2.1
… into 04-29-chore_contracts_dir
v1.8.1
Closed
thedevbirb
reviewed
Apr 30, 2024
merklefruit
changed the title
thedevbirb
force-pushed
the
04-29-chore_contracts_dir
branch
from
a1bac2a to
6e50fc7
Compare
thedevbirb
force-pushed
the
04-29-chore_contracts_dir
branch
from
6e50fc7 to
485c8d0
Compare
merklefruit
added
C: smart-contracts
thedevbirb
reviewed
May 27, 2024
bolt-contracts/script/Counter.s.sol
Outdated
There was a problem hiding this comment.
We can remove this file
There was a problem hiding this comment.
I did it in the upstream PR #35
Will leave it here for now
| /// @notice A challenge requires a bond to be transferred to this contract to avoid spamming. | ||
| /// @param _basedProposer The address of the proposer to challenge | ||
| /// @param _signedCommitment The signed commitment that the proposer is getting challenged for | ||
| function challengeProposer(address _basedProposer, SignedCommitment calldata _signedCommitment) public payable { |
There was a problem hiding this comment.
Should we check if _basedProposer is in the registry or we leave it as it is?
There was a problem hiding this comment.
Comment on lines
315
to
320
| // The genelized index is the index of the merkle tree generated by the merkleization | ||
| // process of a SSZ list of transactions. Since this list is dynamic and can be of maximum | ||
| // length of 2^20 = 1_048_576, the merkleization process fills the tree with empty hashes, | ||
| // therefore this number is an offset from where transactions hash tree root starts. | ||
| // To read more, check out https://github.com/ethereum/consensus-specs/blob/dev/ssz/simple-serialize.md#merkleization | ||
| uint256 generalizedIndex = 1_048_576 + _transactionIndex; |
There was a problem hiding this comment.
The generalized index actually starts at 2^21 = 2_097_152, because we have to take into account one level of the tree that specifies the maximum length of the list
There was a problem hiding this comment.
Good catch ser!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes basic tests for both registry and challenger, but more comprehensive tests will be added in further PRs.
In particular, the challenger logic is security critical so that will need to undergo a lot more effort.