Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup libraries, rm unused code #355

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

merklefruit
Copy link
Collaborator

  • renamed Config to BoltConfig (keeps consistent with the pattern of FileName == ContractName)
  • updated missing licenses and attribution comments where inaccurate
  • deleted libraries that aren't used anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add also whether this library has been audited or not? If so, add a URI in the comments. In this way it is easier to track for us which libraries might need audits on our side or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that I don't know this information. We can try asking or just wait

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@merklefruit merklefruit marked this pull request as ready for review November 7, 2024 19:01
@thedevbirb thedevbirb merged commit 5d64ddf into lore/feat/holesky-launch Nov 8, 2024
2 of 3 checks passed
@thedevbirb thedevbirb deleted the chore/cleanup-libraries branch November 8, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants