chore(holesky/docker): mount volumes on predefined paths #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mempirate
reviewed
Nov 5, 2024
| # | ||
| # NOTE: These enviroment variables take precedence over the ones provided via `env_file`. | ||
| # Reference: https://docs.docker.com/compose/how-tos/environment-variables/envvars-precedence/ | ||
| BOLT_SIDECAR_DELEGATIONS_PATH: "${BOLT_SIDECAR_DELEGATIONS_PATH+/etc/delegations.json}" |
There was a problem hiding this comment.
Will this not set the env var to an empty string?
There was a problem hiding this comment.
if is provided, it will be set to /etc/delegations.json. Otherwise, it will be unset (or set to an empty string). Does it make sense?
…emove last references to deprecated TOML config file
thedevbirb
force-pushed
the
lore/fix/docker-volumes
branch
from
8685ba3 to
0679a49
Compare
merklefruit
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.