Review logs on commitment deadline #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it refers to a function 'try_commit' that doesn't exist
thedevbirb
commented
Nov 12, 2024
| @@ -432,7 +432,6 @@ impl<C: StateFetcher> ExecutionState<C> { | |||
|
|
|||
| /// Commits the transaction to the target block. Initializes a new block template | |||
| /// if one does not exist for said block number. | |||
| /// TODO: remove `pub` modifier once `try_commit` is fully implemented. | |||
There was a problem hiding this comment.
This function try_commit does not exist, so I think this comment is stale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commitment deadline is triggered at every slot regardless of whether we're proposing or not, which was trigger a
WARNlog because the block template could not be found. This not unexpected behaviour, because block templates are created only when accepting commitments, and we do so only when we're the proposer for a block.This PR reviews the logs in this section of the sidecar.