Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proof verification to relay #38

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

thedevbirb
Copy link
Contributor

Closes #28.
This PR introduces the same verification functionality created in https://github.com/chainbound/bolt/pull/11/files#diff-d37e00b1a7a3229e87982a7e48cf2a9f37eb80688297501e95edd50250ee2ea8R335-R409 in the relay. In particular, the check is executed while saving the submit block request on Redis, because the block is converted to a bid which includes the transactions_root needed for verification.

NOTE: at the moment this PR doesn't include an e2e test of the endpoint for the following reasons:

  • the endpoint handler logic is particularly complex to test as whole; in fact at the time of writing the upstream repository doesn't include such test (reference but split its converage into smaller units
  • the verification logic has been extensively tested in the mev-boost PR and with prior work

@thedevbirb thedevbirb force-pushed the feat/bolt-relay-gt branch from c5389e2 to ce5dd22 Compare May 29, 2024 10:28
@thedevbirb thedevbirb force-pushed the feat/relay-proof-2 branch from c9ed5e4 to 5e28064 Compare May 29, 2024 10:39
@thedevbirb thedevbirb force-pushed the feat/relay-proof-2 branch from 5e28064 to 93e7c94 Compare May 29, 2024 10:44
@thedevbirb thedevbirb merged commit 242a660 into feat/bolt-relay-gt May 29, 2024
@thedevbirb thedevbirb deleted the feat/relay-proof-2 branch May 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant