feat: boltup installer + script
#422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, we'll host this on |
thedevbirb
approved these changes
Nov 26, 2024
Comment on lines
+17
to
+33
| while [[ -n $1 ]]; do | ||
| case $1 in | ||
| --) shift; break;; | ||
|
|
||
| -t|--tag) shift; BOLTUP_TAG=$1;; | ||
| --arch) shift; BOLTUP_ARCH=$1;; | ||
| --platform) shift; BOLTUP_PLATFORM=$1;; | ||
| -h|--help) | ||
| usage | ||
| exit 0 | ||
| ;; | ||
| *) | ||
| warn "unknown option: $1" | ||
| usage | ||
| exit 1 | ||
| esac; shift | ||
| done |
There was a problem hiding this comment.
Can this be moved to a separate, documented function?
By documentation I mean something like:
"This function loops as long as $1 (the first positional argument) is not empty, and matches its value against flags. If a flag is found, the argument is discarded (via shift) and the value for the flag is read."
I know, I should RTFM but having gently reminders of bash syntax is nice.
There was a problem hiding this comment.
I didn't move it but I added the comment, as I don't want to introduce untested behaviour in a script that is battle tested (this is what foundry has been using for 2+ years)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick installer for the
boltCLI tool.Mostly copied from the amazing foundryup 👑.
Note
the install script relies on a binary existing on the unstable branch, so this won't work until this PR is merged.
Try it with:
curl -L https://raw.githubusercontent.com/chainbound/bolt/boltup/boltup/install.sh | bashI am not responsible if all your files are deleted, etc etc