Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: built bolt-cli binaries in CI in each new release #426

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Nov 26, 2024

This PR adds a github action automatically triggered upon each new release. (we can also trigger it manually though).
It builds bolt-cli binaries for all platforms, archives them and uploads them to the release assets.

This is a slightly simplified version of https://github.com/foundry-rs/foundry/blob/master/.github/workflows/release.yml

@merklefruit merklefruit changed the base branch from unstable to boltup November 26, 2024 16:39
@merklefruit merklefruit changed the title feat: built bolt-cli binaries in CI feat: built bolt-cli binaries in CI in each new release Nov 26, 2024
Comment on lines +66 to +67
# - name: Install Protoc
# uses: arduino/setup-protoc@v3
Copy link
Contributor

@estensen estensen Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out steps or do you need them later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might be needed if the workflow fails, but I don't know if it will, as I need to merge this to test it.
I'll remove it in a further PR if everything is ok!

Base automatically changed from boltup to unstable November 27, 2024 08:36
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like we're getting better and better CI

@thedevbirb thedevbirb merged commit 53d7d9f into unstable Nov 27, 2024
2 checks passed
@thedevbirb thedevbirb deleted the bolt-cli-binaries-ci branch November 27, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants