Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bolt-boost): add more lints #427

Merged
merged 2 commits into from
Nov 27, 2024
Merged

chore(bolt-boost): add more lints #427

merged 2 commits into from
Nov 27, 2024

Conversation

estensen
Copy link
Contributor

Please protest if you disagree and I'll avoid adding until we have reached agreement 🤝

Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. We should turn this into a template for Chainbound Rust projects along with other defaults (formatters, toolchains, CI). Edit: could we also add this for the bolt-sidecar

@estensen
Copy link
Contributor Author

I like it. We should turn this into a template for Chainbound Rust projects along with other defaults (formatters, toolchains, CI). Edit: could we also add this for the bolt-sidecar

Not sure what the best-practice for Rust monorepos to share tooling like linting is. I'll just copy it for now to bolt-sidecar and bolt-cli.

Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK all clippy lints try to enforce either readability, idiomatic Rust, performance and possible footguns. All good stuff. Feel free to add them! We can eventually consider removing them at a later stage if we find some annoying ones.

@estensen estensen merged commit b360ecf into unstable Nov 27, 2024
4 checks passed
@merklefruit merklefruit deleted the lint-boost branch November 27, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants