Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add operator deregistration commands #498

Merged
merged 6 commits into from
Nov 29, 2024
Merged

feat(cli): add operator deregistration commands #498

merged 6 commits into from
Nov 29, 2024

Conversation

mempirate
Copy link
Contributor

No description provided.

@mempirate mempirate marked this pull request as ready for review November 29, 2024 13:49
@mempirate mempirate requested a review from thedevbirb November 29, 2024 13:59
thedevbirb
thedevbirb requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you modify the test for Symbiotic as well? The ignored test explains the instructions you need to do to run it.

merklefruit
merklefruit approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go if test_eigenlayer_flow is working

bolt-cli/src/cli.rs Show resolved Hide resolved
bolt-cli/src/commands/operators.rs Outdated Show resolved Hide resolved
bolt-cli/src/commands/operators.rs Outdated Show resolved Hide resolved
@merklefruit
Copy link
Collaborator

Also can you update docs in the cli README to include usage of this command?
Also ok to track it in a separate issue @mempirate

@mempirate
Copy link
Contributor Author

@merklefruit added limited docs to README

@mempirate mempirate requested a review from thedevbirb November 29, 2024 15:12
@thedevbirb thedevbirb merged commit 2619485 into unstable Nov 29, 2024
3 checks passed
@thedevbirb thedevbirb deleted the jonas/feat/cli-deregister branch November 29, 2024 15:28
@merklefruit merklefruit mentioned this pull request Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedevbirb thedevbirb thedevbirb approved these changes

@merklefruit merklefruit merklefruit approved these changes

@estensen estensen estensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mempirate @merklefruit @estensen @thedevbirb