Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bolt-sidecar): simplify test pubkey iteration #499

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore(bolt-sidecar): simplify test pubkey iteration #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions bolt-sidecar/src/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,7 @@ impl<C: StateFetcher, ECDSA: SignerECDSA> SidecarDriver<C, ECDSA> {
// determine if the sidecar is the proposer for the given slot. If so, we use the
// validator pubkey or any of its active delegatees to sign constraints.
let signing_pubkey = if self.unsafe_skip_consensus_checks {
// PERF: this is inefficient, but it's only used for testing purposes.
let mut ap = available_pubkeys.iter().collect::<Vec<_>>();
ap.sort();
ap.first().cloned().cloned().expect("at least one available pubkey")
available_pubkeys.iter().min().cloned().expect("at least one available pubkey")
} else {
let validator_pubkey = match self.consensus.validate_request(&inclusion_request) {
Ok(pubkey) => pubkey,
Expand Down