Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sidecar): bump alloy version to 0.7.2 #511

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore(sidecar): bump alloy version to 0.7.2 #511

merged 1 commit into from
Dec 4, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Dec 3, 2024 •
edited
Loading

Now that PooledTransactionsElement implements alloy::consensus::Transaction trait, we can remove some of the functions in our ad-hoc TransactionExt trait. However, we still need some of them, so we need to keep our trait as well.

mempirate
mempirate approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Can you redeploy this version of the sidecar on holesky?

@merklefruit
Copy link
Collaborator Author

Sure, what docker tag should I use for it?

@mempirate mempirate merged commit 5c1208c into unstable Dec 4, 2024
3 checks passed
@mempirate mempirate deleted the chore/sidecar/update-alloy branch December 4, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

@thedevbirb thedevbirb Awaiting requested review from thedevbirb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merklefruit @mempirate