-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add web3signer
KeySource
#513
feat(cli): Add web3signer
KeySource
#513
Conversation
Hey team, I think this is a good stage for milestone check-in to receive some early feedback. There are still some small changes I need to make such as figuring out the TLS on Thank you 🙏 |
Hey @Edwardjes thanks a lot for this draft. Will take a look shortly and will get back as soon as I have a review ready |
691b7a4
to
e176b5b
Compare
web3signer
KeySourceweb3signer
KeySource
Merge conflicts and TLS fixed. Have taken this out of draft now 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I've tested it locally with web3signer built from source and the tests worked and I was able to generate a delegation from this.
Amazing work @Edwardjes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot for the contribution. I have just two nits.
I defer to @merklefruit for merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Edwardjes 🚀
CI is red due to some secrets configuration stuff but this is gtg.
Addresses: #365 towards #502
Overview
This PR adds support for consensys'
Web3Signer
as remote signer for generating BLS key delegations.This will allow for the listing and signing of
delegate
messages using Web3Signer.Tests have been added which follow a similar pattern to Dirk.
E.g.
cargo test --package bolt --bin bolt -- common::web3signer::tests --exact --show-output --ignored
The readme has been updated to capture these changes README here.
Note: that
web3signer
must be built from source as the commitboost API has not been released