Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add web3signer KeySource #513

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

tsnewnami
Copy link
Contributor

@tsnewnami tsnewnami commented Dec 3, 2024

Addresses: #365 towards #502

Overview

This PR adds support for consensys' Web3Signer as remote signer for generating BLS key delegations.
This will allow for the listing and signing of delegate messages using Web3Signer.

Tests have been added which follow a similar pattern to Dirk.
E.g. cargo test --package bolt --bin bolt -- common::web3signer::tests --exact --show-output --ignored

The readme has been updated to capture these changes README here.

Note: that web3signer must be built from source as the commitboost API has not been released

@tsnewnami
Copy link
Contributor Author

tsnewnami commented Dec 3, 2024

Hey team, I think this is a good stage for milestone check-in to receive some early feedback. There are still some small changes I need to make such as figuring out the TLS on reqwest and merge conflicts. Though the main meat of functionality should be there.

Thank you 🙏

@tsnewnami tsnewnami marked this pull request as draft December 3, 2024 21:48
@merklefruit
Copy link
Collaborator

merklefruit commented Dec 4, 2024

Hey @Edwardjes thanks a lot for this draft. Will take a look shortly and will get back as soon as I have a review ready

@merklefruit merklefruit added T: feature Type: Feature C: bolt-cli Component: bolt CLI labels Dec 4, 2024
@merklefruit merklefruit linked an issue Dec 4, 2024 that may be closed by this pull request
@tsnewnami tsnewnami force-pushed the edwardjes/web3signer branch from 691b7a4 to e176b5b Compare December 4, 2024 23:43
@tsnewnami tsnewnami marked this pull request as ready for review December 5, 2024 07:21
bolt-cli/src/cli.rs Outdated Show resolved Hide resolved
@tsnewnami tsnewnami changed the title [DRAFT] feat(cli): Add web3signer KeySource feat(cli): Add web3signer KeySource Dec 5, 2024
@tsnewnami
Copy link
Contributor Author

Merge conflicts and TLS fixed. Have taken this out of draft now 🙏

Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've tested it locally with web3signer built from source and the tests worked and I was able to generate a delegation from this.

Amazing work @Edwardjes!

Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for the contribution. I have just two nits.
I defer to @merklefruit for merging

bolt-cli/src/commands/delegate/web3signer.rs Outdated Show resolved Hide resolved
bolt-cli/src/common/web3signer.rs Show resolved Hide resolved
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Edwardjes 🚀
CI is red due to some secrets configuration stuff but this is gtg.

@merklefruit merklefruit merged commit 941dd23 into chainbound:unstable Dec 5, 2024
2 of 3 checks passed
@tsnewnami tsnewnami deleted the edwardjes/web3signer branch December 5, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-cli Component: bolt CLI T: feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cli): Add web3signer KeySource
3 participants