chore: use more specific error types

bolt-sidecar/src/api/commitments/handlers.rs

@@ -65,9 +65,9 @@ pub async fn rpc_entrypoint(
             };
 
             // Parse the inclusion request from the parameters
-            let mut inclusion_request: InclusionRequest = serde_json::from_value(request_json)
-                .map_err(|e| RejectionError::ValidationFailed(e.to_string()))
-                .inspect_err(|e| error!("Failed to parse inclusion request: {:?}", e))?;
+            let mut inclusion_request = serde_json::from_value::<InclusionRequest>(request_json)
+                .map_err(RejectionError::Json)
+                .inspect_err(|err| error!(?err, "Failed to parse inclusion request"))?;
 
             debug!(?inclusion_request, "New inclusion request");
 

bolt-sidecar/src/api/commitments/spec.rs

@@ -34,6 +34,9 @@ pub enum CommitmentError {
     /// Duplicate request.
     #[error("Duplicate request")]
     Duplicate,
+    /// No available public key to sign commitment request with for a given slot.
+    #[error("No available public key to sign request with (slot {0})")]
+    NoAvailablePubkeyForSlot(u64),
     /// Internal server error.
     #[error("Internal server error")]
     Internal,
@@ -73,6 +76,11 @@ impl IntoResponse for CommitmentError {
                 Json(JsonResponse::from_error(-32002, self.to_string())),
             )
                 .into_response(),
+            Self::NoAvailablePubkeyForSlot(_) => (
+                StatusCode::INTERNAL_SERVER_ERROR,
+                Json(JsonResponse::from_error(-32008, self.to_string())),
+            )
+                .into_response(),
             Self::NoSignature => {
                 (StatusCode::BAD_REQUEST, Json(JsonResponse::from_error(-32003, self.to_string())))
                     .into_response()
@@ -117,6 +125,9 @@ pub enum RejectionError {
     /// State validation failed for this request.
     #[error("Validation failed: {0}")]
     ValidationFailed(String),
+    /// JSON parsing error.
+    #[error("JSON parsing error: {0}")]
+    Json(#[from] serde_json::Error),
 }
 
 /// Implements the commitments-API: <https://chainbound.github.io/bolt-docs/api/rpc>

bolt-sidecar/src/driver.rs

@@ -317,7 +317,7 @@ impl<C: StateFetcher, ECDSA: SignerECDSA> SidecarDriver<C, ECDSA> {
                 self.constraints_client.find_signing_key(validator_pubkey, available_pubkeys)
             else {
                 error!(%target_slot, "No available public key to sign constraints with");
-                let _ = response.send(Err(CommitmentError::Internal));
+                let _ = response.send(Err(CommitmentError::NoAvailablePubkeyForSlot(target_slot)));
                 return;
             };