refactor to comply to specs + SSZ enc/dec of spec types #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
changed the title
thedevbirb
added
C: mev-boost-relay
merklefruit
approved these changes
Jun 4, 2024
| Signature phase0.BLSSignature `ssz-size:"96"` | ||
| ProposerIndex uint64 | ||
| const ( | ||
| MAX_CONSTRAINTS_PER_SLOT = 256 |
There was a problem hiding this comment.
This should be documented, maybe on our docs website?
There was a problem hiding this comment.
I've added a comment above the constant that says this is not final yet, and a related issue #61.
|
|
||
| type SignedConstraints struct { | ||
| Message *ConstraintsMessage `json:"message"` | ||
| Signature phase0.BLSSignature `ssz-size:"96" json:"signature"` |
There was a problem hiding this comment.
Let's mark somewhere the fact that we are moving to ECDSA signatures for constraints
There was a problem hiding this comment.
I think we're now using 2 different signature types in the relay and mev-boost right?
There was a problem hiding this comment.
damn, this is insane, good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns as much as possible the relay codebase to the Bolt specs and closes #49 and #21 . It consists of three main parts:
SignedConstraintsand its inner types (with some tests!). This has been necessary in order to produce a compliant (to consensus-specs) signature digest of the typeConstraintsMessage.Fortunately, the SSZ work can be re-used in various part of the stack if needed.
NOTE: this PR doesn't introduce Merkle Multiproofs yet. See #55 for more details.