-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): BoltManagerV3
#551
Conversation
3fb4ebc
to
ae43303
Compare
tests are working locally for me, not sure what's going on with CI 🥲 |
not sure, tests pass locally for me too |
ae43303
to
2b0ca89
Compare
We also need a function to check if an operator has enough stake:
|
2b0ca89
to
92ea993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, testing fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has a wrong name -- it should be IBoltManagerV3.sol
and not IBoltManagerv3.sol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh damn, I totally missed that, probably why CI fails haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that was it, thanks for noticing this!!
Do you want to add them or will you add them in the next iteration? |
Since this is a last-minute change and we're going to deprecate this contract with the new OperatorsRegistry, I am going to drop those updates from here as it would be a waste of time. They will be part of the work in new contracts (WIP) |
Deployed on Holesky |
This PR introduces a new version of BoltManager that allows for fetching operator data through view methods.
New functionality
function updateOperatorRPC(string calldata rpc) external
to update an operator's RPC endpointfunction getOperatorData(address operator) external view returns (EnumerableMapV3.Operator memory operatorData)
to get the current operator data, like middleware, start time and rpc endpoint.function getAllOperatorsData() external view returns (EnumerableMapV3.Operator[] memory operatorData)
to get all operators data in a single call.KeyNotFound
error #397BoltManager
#408